ASPN ActiveState Programmer Network
ActiveState
/ Home / Perl / PHP / Python / Tcl / XSLT /
/ Safari / My ASPN /
Cookbooks | Documentation | Mailing Lists | Modules | News Feeds | Products | User Groups


Recent Messages
List Archives
About the List
List Leaders
Subscription Options

View Subscriptions
Help

View by Topic
ActiveState
.NET Framework
Open Source
Perl
PHP
Python
Tcl
Web Services
XML & XSLT

View by Category
Database
General
SOAP
System Administration
Tools
User Interfaces
Web Programming
XML Programming


MyASPN >> Mail Archive >> boost
boost
Re: [boost] Review: Boost Test Library
by Jens Maurer other posts by this author
Feb 13 2001 9:18PM messages near this date
Re: [boost] Review: Boost Test Library | Re: [boost] Review: Boost Test Library
These are my personal comments. They are not to be confused with my
role as review manager.

In general, I vote for acceptance of the library.

Detailed comments:

test_tools.hpp includes a definition for main() only if
BOOST_INCLUDE_MAIN is defined. This seems prudent, but it means that
the test programs such as test_tools_example.cpp and test_tools_fail*.cpp
should define it before including the file.
It seems inappropriate to do so in the compiler.cfg for the
regression tests.

I'd rather move the test tools to some boost/test/XXX.hpp subdirectory,
because we expect the addition of unit tests as well. Besides, the
usage for the test headers is rather specific, so there's no need
to put it at the same level as e.g. smart pointers.

The return code in the example of execution_tools.htm needs to be adjusted
to the current state in the actual *.cpp files.

Can we have the output formatting in catch_exceptions.hpp separated
into another static function so that the **** doesn't repeat too
often in the source? Nothing fancy, just
std::string format_exception(const char * name, const char *info);
where info is usually ex.what() except for a few special cases.

test_tools.htm: I like the CRITICAL part suggested in another mail
instead of the _ASSERT suffix. I think the _CRITICAL suffix is more
logical than putting it in between somewhere.

Jens Maurer
Thread:
Jens Maurer
Ed Brey
Beman Dawes
Jens Maurer
Beman Dawes


Jens Maurer

Jens Maurer
David Abrahams
David Abrahams

Mark Rodgers

Kevlin Henney

Kevlin Henney

Ronald Garcia

Mark Rodgers
Ed Brey
David Abrahams

David Abrahams
David Abrahams
Beman Dawes
Ed Brey

Jens Maurer
Beman Dawes

Ed Brey

Privacy Policy | Email Opt-out | Feedback | Syndication
© ActiveState Software Inc. All rights reserved