ASPN ActiveState Programmer Network
ActiveState
/ Home / Perl / PHP / Python / Tcl / XSLT /
/ Safari / My ASPN /
Cookbooks | Documentation | Mailing Lists | Modules | News Feeds | Products | User Groups


Recent Messages
List Archives
About the List
List Leaders
Subscription Options

View Subscriptions
Help

View by Topic
ActiveState
.NET Framework
Open Source
Perl
PHP
Python
Tcl
Web Services
XML & XSLT

View by Category
Database
General
SOAP
System Administration
Tools
User Interfaces
Web Programming
XML Programming


MyASPN >> Mail Archive >> libwin32-perl
libwin32-perl
Re: Please review Win32-0.27_02
by Steve Hay other posts by this author
May 16 2007 3:12AM messages near this date
Please review Win32-0.27_02 | RE: Please review Win32-0.27_02
Jan Dubois wrote:
>  I've uploaded Win32-0.27_02.tar.gz to CPAN. The search.cpan.org diff is
>  much bigger than it needs to be, so I have attached a better diff for
>  review to this message.

Testing on Win32 with VC6, there's one warning produced when building:

Didn't find a 'MODULE ... PACKAGE ... PREFIX' line

Otherwise looks OK with a threaded bleadperl, but with a non-threaded 
one (I built with "nmake USE_MULTI=undef USE_ITHREADS=undef 
USE_IMP_SYS-undef") lots of tests fail:

C:\Temp\Win32-0.27_02> nmake test

Microsoft (R) Program Maintenance Utility   Version 6.00.8168.0
Copyright (C) Microsoft Corp 1988-1998. All rights reserved.

         C:\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" 
"test_harness(0, 'bl
ib\lib', 'blib\arch')" t/*.t
t/CreateFile..................ok      144 ms
t/ExpandEnvironmentStrings....ok       64 ms
t/GetCurrentThreadId..........skipped
         all skipped: Test requires fork emulation
t/GetFileVersion..............skipped
         all skipped: Only ActivePerl seems to set the perl.exe fileversion
t/GetFolderPath...............ok       87 ms
t/GetFullPathName.............# Test 1 got: "." (t/GetFullPathName.t at 
line 12)

t/GetFullPathName.............NOK 1/16#   Expected: 
"C:\\Temp\\Win32-0.27_02"
#  t/GetFullPathName.t line 12 is: ok(scalar 
Win32::GetFullPathName('.'), $cwd);

# Test 2 got: "." (t/GetFullPathName.t at line 13)
#   Expected: "C:\\Temp\\"
#  t/GetFullPathName.t line 13 is: ok((Win32::GetFullPathName('.'))[0], 
"$dir\\"
);
t/GetFullPathName.............NOK 2/16# Test 3 got: "" 
(t/GetFullPathName.t at l
ine 14)
t/GetFullPathName.............NOK 3/16#   Expected: "Win32-0.27_02"
#  t/GetFullPathName.t line 14 is: ok((Win32::GetFullPathName('.'))[1], 
$file);
# Test 4 got: "./" (t/GetFullPathName.t at line 16)
t/GetFullPathName.............NOK 4/16#   Expected: 
"C:\\Temp\\Win32-0.27_02\\"
#  t/GetFullPathName.t line 16 is: ok((Win32::GetFullPathName('./'))[0], 
"$cwd\");
# Test 5 got: ".\\" (t/GetFullPathName.t at line 17)
t/GetFullPathName.............NOK 5/16#   Expected: 
"C:\\Temp\\Win32-0.27_02\\"
#  t/GetFullPathName.t line 17 is: 
ok((Win32::GetFullPathName('.\\'))[0], "$cwd\");
# Test 9 got: "" (t/GetFullPathName.t at line 22)
#   Expected: "Win32-0.27_02"
t/GetFullPathName.............ok 6/16#  t/GetFullPathName.t line 22 is: 
ok((Win3
2::GetFullPathName($cwd))[1], $file);
# Test 10 got: "\\Temp\\" (t/GetFullPathName.t at line 24)
#    Expected: "C:\\Temp\\\0in32-0.27_02"
t/GetFullPathName.............NOK 9/16#  t/GetFullPathName.t line 24 is: 
ok(scal
ar Win32::GetFullPathName(substr($cwd,2)), $cwd);
# Test 11 got: "\\Temp\\" (t/GetFullPathName.t at line 25)
#    Expected: "C:\\Temp\\"
t/GetFullPathName.............NOK 10/16#  t/GetFullPathName.t line 25 
is: ok((Wi
n32::GetFullPathName(substr($cwd,2)))[0], "$dir\\");
# Test 12 got: "" (t/GetFullPathName.t at line 26)
#    Expected: "Win32-0.27_02"
t/GetFullPathName.............NOK 11/16#  t/GetFullPathName.t line 26 
is: ok((Wi
n32::GetFullPathName(substr($cwd,2)))[1], $file);
t/GetFullPathName.............NOK 12/16# Test 13 got: "/Foo Bar/" 
(t/GetFullPath
Name.t at line 28)
t/GetFullPathName.............NOK 13/16#    Expected: "C:\\Foo Bar\\"
#  t/GetFullPathName.t line 28 is: ok(scalar 
Win32::GetFullPathName('/Foo Bar/')
, substr($cwd,0,2)."\\Foo Bar\\");
# Test 14 got: "." (t/GetFullPathName.t at line 31)
t/GetFullPathName.............NOK 14/16#    Expected: "C:\\Temp"
#  t/GetFullPathName.t line 31 is: ok(scalar 
Win32::GetFullPathName('.'), $dir);

# Test 15 got: "Win32-0.27_02" (t/GetFullPathName.t at line 33)
#    Expected: "C:\\Temp\\"
t/GetFullPathName.............NOK 15/16#  t/GetFullPathName.t line 33 
is: ok((Wi
n32::GetFullPathName($file))[0], "$dir\\");
# Test 16 got: "" (t/GetFullPathName.t at line 34)
t/GetFullPathName.............NOK 16/16#    Expected: "Win32-0.27_02"
#  t/GetFullPathName.t line 34 is: 
ok((Win32::GetFullPathName($file))[1], $file)
;
t/GetFullPathName.............FAILED tests 1-5, 9-16
         Failed 13/16 tests, 18.75% okay
t/GetLongPathName.............ok       73 ms
t/GetOSVersion................ok       68 ms
t/GuidGen.....................ok       69 ms
t/Unicode.....................ok 1/12# Test 5 got: "" (t/Unicode.t at 
line 59)
t/Unicode.....................NOK 5/12#   Expected: 
"C:\\Temp\\Win32-0.27_02\\Fo
o \x{394}\x{419} Bar \x{5E7}\x{645} Baz"
#  t/Unicode.t line 59 is: ok($long, 
Win32::GetLongPathName($home)."\\$dir");
# Test 7 got: "C:\\Temp\\Win32-0.27_02\\Foo \x{394}\x{419} Bar 
\x{5E7}\x{645} Ba
z" (t/Unicode.t at line 63)
t/Unicode.....................NOK 7/12#   Expected: ""
#  t/Unicode.t line 63 is: ok(Win32::GetLongPathName(Win32::GetCwd()), 
$long);
# Test 8 got: "C:\\Temp\\Win32-0.27_02\\Foo \x{394}\x{419} Bar 
\x{5E7}\x{645} Ba
z" (t/Unicode.t at line 67)
t/Unicode.....................NOK 8/12#   Expected: ""
#  t/Unicode.t line 67 is: ok(Win32::GetLongPathName($cwd), $long);
# Test 12 got: "C:\\Temp\\Win32-0.27_02\\Foo \x{394}\x{419} Bar 
\x{5E7}\x{645} B
az" (t/Unicode.t at line 75)
t/Unicode.....................NOK 12/12#    Expected: ""
#  t/Unicode.t line 75 is: ok(Win32::GetLongPathName(Win32::GetCwd()), 
$long);
t/Unicode.....................FAILED tests 5, 7-8, 12
         Failed 4/12 tests, 66.67% okay
Failed Test         Stat Wstat Total Fail  List of Failed
-------------------------------------------------------------------------------
t/GetFullPathName.t               16   13  1-5 9-16
t/Unicode.t                       12    4  5 7-8 12
2 tests skipped.
Failed 2/10 test scripts. 17/85 subtests failed.
Files=10, Tests=85,  1 wallclock secs ( 0.00 cusr +  0.00 csys =  0.00 CPU)
Failed 2/10 test programs. 17/85 subtests failed.
NMAKE : fatal error U1077: 'C:\perl\bin\perl.exe' : return code '0xff'
Stop.

-- 
Thread:
Jan Dubois
Steve Hay
Jan Dubois
Steve Hay
Jan Dubois
Steve Hay
Jan Dubois
Sisyphus
Jan Dubois

Privacy Policy | Email Opt-out | Feedback | Syndication
© ActiveState Software Inc. All rights reserved