Paul M Jones wrote:
>  ========
>  Overview
>  --------
>  
>  DB_Simple attempts to fill the space between DB, MDB, and DB_DataObject
>  by supporting automated SQL queries, providing and easy to use
>  configuration system, and abstracting datatypes.
>  
>  See the two attached files for the DB_Simple class and an example
>  extension class.
>  
<snip /> 

Firstly I'd just like to say that this has been THE best proposal I've 
seen so far, well done on a well thought out package and just as 
importantly a well thought out proposal. Just the one criticism, putting 
the source online as .phps would have been a preffered over the attached 
files.

I think that we should *really* think about offering this up as a sample 
on how to propose a package.

Now, about the package, it looks good, however I feel that those with 
more knowledge of MDB et al; can better give there opinion on its 
neccesity. I wouldn't use this, but I am sure plenty of people would...

Also, I see no reason for you to be extending PEAR, you only see to use 
PEAR::isError and as you call that statically, no extension of the PEAR 
class is needed.

Thats really the only problem I've seen in my quick overview of the code...

well done once again on the great proposal, good luck with it! :)

- Davey

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php