I completely disagree with this. You're basically advocating code  
duplication. What should happen is one of the following:

1.) Optional dependency (noted in the docs)

2.) Up your PHP requirements

3.) Let people running old versions of PHP install PHP_Compat on  
their own

Copying and pasting code from one package to another should be  
discouraged IMO.

--Joe

On Jun 19, 2006, at 11:14 AM, Pierre wrote:

>  On 6/19/06, Olivier Guilyardi <ojaiml@[...].net> wrote:
> > Pierre wrote:
> >
> > >> I've included the function we need directly into  
> > Structures_DataGrid,
> > >> and am
> > >> removing the dependency completely.
> > >
> > > No, as we defined than a package cannot depend on php_compat.
> > > Especially not when you are in beta. It makes no sense.
> >
> > I said that I "included" the function, that is : I made a function  
> > named
> > "Structures_DataGrid_http_build_query()", and am not using  
> > PHP_Compat's
> > http_build_query() anymore.
> 
>  That's fine and even better, in my oppinion. That's what php_compat
>  should be, a copy/paste package (in most cases)  :-)
> 
>  --Pierre
> 
>  -- 
>  PEAR QA Mailing List (http://pear.php.net/)
>  To unsubscribe, visit: http://www.php.net/unsub.php
> 

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php