Olivier Guilyardi wrote:
>  Greg Beaver wrote:
>  
> > Olivier Guilyardi wrote:
> >
> >>
> >> I said that I "included" the function, that is : I made a function named
> >> "Structures_DataGrid_http_build_query()", and am not using PHP_Compat's
> >> http_build_query() anymore.
> >>
> >> Is there anything wrong with this ? (I'm not sure what you were talking
> >> about in the above citation)
> >
> >
> > I'd say a good rule of thumb is if you only need about 30 lines of code
> > or so, and it isn't too complex (i.e. you can maintain it, and the
> > chance of a bug is low), cut-and-paste is usually better than a
> > dependency.
>  
>  
>  That's 60 lines in our case.
>  
>  But, I would have liked :
>  - a conditional dependency, to do : if php < 5 then require php_compat

This is too complicated from the installer end.  You can, of course,
make it so that the file containing the function is only installed if
PHP < 5.

>  - or "pear package-validate" to detect that php_compat was required, and
>  issue an error

That would be essentially putting a really brilliant brain inside
package-validate, something that is, to say the least, extremely
complicated.

In other words, that will never be a standard part of PEAR version 1.x.
 There is some remote possibility that PEAR2 (vaporware atm) could be
modular enough to support something with this using PHP_Parser, but
that's WAYYYYY in the future.

Greg

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php