Graham Christensen (http://pear.php.net/user/itrebal) has commented on the proposal for Netw
orking::Net_CheckMAC.

Comment:

($uppercase) ? $macaddr = strtoupper($macaddr) : $macaddr =
strtolower($macaddr);
Either switch that to an if-else statement, or do:
$macaddr = ($uppercase)?strtoupper($macaddr):strtolower($macaddr);
Much cleaner and easier to read.

Note: Ternaries are generally avoided.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=454

-- 
Sent by PEPr, the automatic proposal system at http://pear.php.net

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php