[ANN] Logic Expressions
by Daniel Altman other posts by this author
Nov 26 2003 6:09PM messages near this date
[perl #24556] Perl 5.8.2: unresolvable symbol PL_perl_destruct_level
|
Smoke [5.9.0] 21788 FAIL(Fc) bsd/os 4.1 (i386/1 cpu)
On Wed, Nov 05, 2003 at 12:50:25AM -0800, Stas Bekman wrote:
> Here is the "fix" that prevent the segfault conditions. Though there is
> more problems with Benchmarks.pm which need to be fixed. Next we look at
> the segfault itself.
>
> --- Benchmark.pm.orig 2003-11-05 00:36:58.000000000 -0800
> +++ Benchmark.pm 2003-11-05 00:38:26.000000000 -0800
> @@ -890,7 +890,7 @@
> @vals = sort { $a->[7] <=> $b->[7] } @vals;
>
> # If more than half of the rates are greater than one...
> - my $display_as_rate = $vals[$#vals>>1]->[7] > 1;
> + my $display_as_rate = @vals ? ($vals[$#vals>>1]->[7] > 1) : 0;
Since $foo> >1 is just an clever way to say int $foo/2, but in an alien
tongue, that should probably just be:
my $display_as_rate = $vals[$#vals/2]-> [7] > 1;
no?
--
Michael G Schwern schwern@[...].com http://www.pobox.com/~schwern/
<mendel> ScHWeRnsChweRN sChWErN SchweRN SCHWErNSChwERnsCHwERN
sChWErn ScHWeRn schweRn sCHWErN schWeRn scHWeRN
SchWeRN scHWErn SchwErn scHWErn ScHweRN sChwern
scHWerN scHWeRn scHWerN ScHwerN SChWeRN scHWeRn
SchwERNschwERn SCHwern sCHWErN SCHWErN sChWeRn
|