I would have been +0 for 5, I'm -1 for 5.1. FETCH_CONSTANT is not a
terribly expensive operation (as opposed to registering constants with
define()), and something like this is *easy* to optimize in a compiler
cache/optimizer.  End of the day, we shouldn't break BC in any way
during a point release (or at all) unless its necessary/important,
this does meet that criteria.

-Sterling

On Fri, 16 Jul 2004 08:20:43 -0700, Andi Gutmans <andi@[...].com>  wrote:
>  I don't think it's critical to include this patch, but I do think it'd be a
>  good thing.
>  Do you really think it'll break BC for many applications? How many people
>  have functions that use null(), false(), true()?
>  
>  Andi
>  
>  
>  
>  At 08:17 AM 7/16/2004 -0700, Sterling Hughes wrote:
>  >oh, i didn't notice it at all, which i'll buy is probably my fault. :)
>  >
>  >This  seems like its a bad optimization.  I believing in breaking BC
>  >in some cases when its absolutely necessary, but an optimization like
>  >this one could easily happen at the level of an optimizer, like APC or
>  >Zend's product.  Why are we breaking BC for this?
>  >
>  >-sterling
>  >
>  >On Fri, 16 Jul 2004 09:55:57 +0200, Marcus Boerger <helly@[...].net> wrote:
>  > > Hello Sterling,
>  > >
>  > > it was on internals and in TODO-5.1. Maybe not many people noticed
>  > > it between discussing typehints and ifsetor.
>  > >
>  > > marcus
>  > >
>  > >
>  > >
>  > > Friday, July 16, 2004, 9:12:28 AM, you wrote:
>  > >
>  > > > woops, discussion should be on internals@[...]..
>  > >
>  > > > ---------- Forwarded message ----------
>  > > > From: Sterling Hughes <sterling.hughes@[...].com>
>  > > > Date: Fri, 16 Jul 2004 00:11:53 -0700
>  > > > Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 /
>  > > > zend_language_parser.y zend_language_scanner.l
>  > > > To: Marcus Boerger <helly@[...].net>
>  > > > Cc: zend-engine-cvs@[...].net
>  > >
>  > > > this breaks bc - it should at least be discussed....
>  > >
>  > > > -sterling
>  > >
>  > > > On Fri, 16 Jul 2004 06:50:58 -0000, Marcus Boerger <helly@[...].net> wrote:
>  > > >> helly           Fri Jul 16 02:50:58 2004 EDT
>  > > >>
>  > > >>   Modified files:
>  > > >>     /ZendEngine2        zend_language_parser.y zend_language_scanner.l
>  > > >>   Log:
>  > > >>   - Speed up by making null/false/true reserved word which allows to
>  > drop
>  > > >>     an opcode (FETCH_CONSTANT) for every usage.
>  > > >>
>  > >
>  > >
>  >
>  >--
>  >PHP Internals - PHP Runtime Development Mailing List
>  >To unsubscribe, visit: http://www.php.net/unsub.php
>  
>  
>  
>  --
>  PHP Internals - PHP Runtime Development Mailing List
>  To unsubscribe, visit: http://www.php.net/unsub.php
>  
> 

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php