ASPN ActiveState Programmer Network
ActiveState
/ Home / Perl / PHP / Python / Tcl / XSLT /
/ Safari / My ASPN /
Cookbooks | Documentation | Mailing Lists | Modules | News Feeds | Products | User Groups


Recent Messages
List Archives
About the List
List Leaders
Subscription Options

View Subscriptions
Help

View by Topic
ActiveState
.NET Framework
Open Source
Perl
PHP
Python
Tcl
Web Services
XML & XSLT

View by Category
Database
General
SOAP
System Administration
Tools
User Interfaces
Web Programming
XML Programming


MyASPN >> Mail Archive >> php-dev
php-dev
#44964 [Bgs]: DirectoryIterator assignment within foreach()
by Phpbugs At Rjharrison Dot Org other posts by this author
May 11 2008 1:28PM messages near this date
#44964 [NEW]: DirectoryIterator assignment within FOREACH | #44964 [Asn->Bgs]: DirectoryIterator assignment within foreach()
ID:               44964
 User updated by:  phpbugs at rjharrison dot org
 Reported By:      phpbugs at rjharrison dot org
 Status:           Bogus
 Bug Type:         SPL related
 Operating System: Linux (fedora core 6  i think)
 PHP Version:      5.2.6
 Assigned To:      colder
 New Comment:

Hi Colder,

I did consider cloning the object, but the behaviour is still wrong
(imo):-

// $files[] = $file; change to -> 
$files[] = clone $file;


Actual result:
--------------
test.php / 18 bytes
. / 4096 bytes
.. / 4096 bytes

Second loop:-
test.php / 18 bytes
test.php / 18 bytes
test.php / 18 bytes


Also, I disagree that original report expected behaviour (from a PHP
User's perspective), even if it makes sense from an SPL perspective.

DirectoryIterator::current() returning _itself_ seems pretty crazy to
me? Why doesn't it return an SplFileInfo object, representing the file
in question?


Previous Comments:
------------------------------------------------------------------------

[2008-05-11 18:10:46] colder@[...].net

Sorry, but your problem does not imply a bug in PHP itself.  For a
list of more appropriate places to ask for help using PHP, please
visit http://www.php.net/support.php as this bug system is not the
appropriate forum for asking support questions.  Due to the volume
of reports we can not explain in detail here why your report is not
a bug.  The support channels will be able to provide an explanation
for you.

Thank you for your interest in PHP.

Even if it's odd, this is actually expected,
DirectoryIterator::current() returns itself, so you're storing the same
iterator multiple times in your array, consider either using clone or
fetching directly the informations in your foreach.

------------------------------------------------------------------------

[2008-05-10 19:25:02] phpbugs at rjharrison dot org

Description:
------------
When looping over a $directorIterator using FOREACH something goes
wrong when assigning the "as" variable to an array.




Reproduce code:
---------------
$filePath   = 'PUT YOUR TEST PATH HERE';
$dir        = new DirectoryIterator($filePath);
$files      = array();

foreach ($dir as $file){
    $files[] = $file;
    echo $file-> getFilename(), " / ", $file->getSize(), " bytes\n";
}

echo "\nSecond loop:-\n";

foreach ($files as $file2){
    echo $file2-> getFilename(), " / ", $file2->getSize(), " bytes\n";
}


Expected result:
----------------
(Depends on the files but assuming a single file in the directory)

test.php / 18 bytes
. / 4096 bytes
.. / 4096 bytes

Second run:-
test.php / 18 bytes
. / 4096 bytes
.. / 4096 bytes

Actual result:
--------------
test.php / 18 bytes
. / 4096 bytes
.. / 4096 bytes

Second run:-
 / 4096 bytes
 / 4096 bytes
 / 4096 bytes


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=44964&edit=1
Thread:
Phpbugs At Rjharrison Dot Org
Phpbugs At Rjharrison Dot Org
colder
colder

Privacy Policy | Email Opt-out | Feedback | Syndication
© ActiveState Software Inc. All rights reserved