From: chrisj
Date: Mon Jun  4 20:39:03 2001
Modified files:
      php-lib-stable/TODO

Log message:

Added some bugs to be checked out.


Index: php-lib-stable/TODO
diff -u php-lib-stable/TODO:1.6 php-lib-stable/TODO:1.7
--- php-lib-stable/TODO:1.6	Fri May 11 02:38:17 2001
+++ php-lib-stable/TODO	Mon Jun  4 20:38:33 2001
@@ -1,5 +1,5 @@
 
-$Id: TODO,v 1.6 2001/05/11 00:38:17 chrisj Exp $
+$Id: TODO,v 1.7 2001/06/04 18:38:33 chrisj Exp $
 
 Things To Do for Release 7.2d:
 
@@ -34,6 +34,40 @@
 
 
 *) Others as they are found, reported or documented.
+
+	Some possible bugs reported by Forrest J Cavalier III
+	(forrest@mibsoftware.com):
+
+	I am using a new tool for PHP code auditing.
+
+	I found three items while auditing table.inc
+	of 7.2.b.
+
+	----------------------------------------------
+	function show_table_page_rows()
+
+	uses $key,$val, but does not set them:
+	$this-> table_row($row, $key, $val, $class);
+
+	(This may be serious, I don't know)
+
+	----------------------------------------------
+	function show_table_heading_cells()
+	has the line:
+	$cell = 0;
+
+	which I think that should be $col = 0;  (or
+	the later line in that function should have
+	$cell++)
+
+	Since table_heading_cell() doesn't use the first
+	argument, it seems like there is no observable
+	defect.
+
+	----------------------------------------------
+	function table_heading_cell() 
+
+	sets $found, but never uses it.
 
 
 2. Certify correct for use with both PHP3 and PHP4.



---------------------------------------------------------------------
To unsubscribe, e-mail: phplib-dev-unsubscribe@[...].de
For additional commands, e-mail: phplib-dev-help@lists.netuse.de