I always strive for perfection, because I am a very pedantic person. Every
little bug annoys me to the max and I can't get over that. I love the fact
that this kind of ugly code is going away and also that "all remnants of the
old naming scheme will be dropped". Can't wait for Python 3.0 and wxPython
that'll be based on it! ;)



On Wed, May 7, 2008 at 10:22 PM, Tim Roberts <timr@[...].com>  wrote:

>  Chester wrote:
> 
>  > I just want to make wxPython source code perfect. It is better to do
>  > if 'wxPython.wx' in sys.modules:    rather than   if
>  > sys.modules.has_key('wxPython.wx'):
>  >
>  >
> 
>  You forgot to say "in my opinion."
> 
>   Though the latter gives the exact same functionality as the former, it
>  > is still better to do the former. The reason is that the method
>  > has_key() has been deprecated in Python 3.0, and I can see why. You
>  > might still ask why? Well, because it is ugly. :)  Guido van Rossum
>  > agrees. The  in  statement is a very powerful statement. Use it! :)
>  >
>  >
> 
>  There are perhaps 2,000 stylistic improvements that could be made to the
>  wxPython source code to improve its readability.  When ranked in order of
>  importance, this change is approximately number 1,920.
> 
>  I think that's really the point several of us would like to make.  When
>  the time comes to port wxPython to Python 3.0, there are a HUGE number of
>  changes that will be required.  This particular one is something that will
>  be handled by the automated tool.  It isn't really productive for you to
>  point it out.
> 
>  You should also realize that the particular file you targeted (media.py)
>  is automatically generated during the build process, and is required ONLY
>  for backwards compatibility with the old wxPython naming convention.  When
>  wxPython does finally move to Python 3.0, my assumption is that all remnants
>  of the old naming scheme will be dropped, so this particular file will no
>  longer exist.  Given that, there is absolutely no reason to change this now.
>   Introducing changes for no reason is little more than an opportunity to
>  introduce new bugs.
> 
>  --
>  Tim Roberts, timr@[...].com
>  Providenza & Boekelheide, Inc.
> 
>  _______________________________________________
>  wxpython-users mailing list
>  wxpython-users@[...].org
>  http://lists.wxwidgets.org/mailman/listinfo/wxpython-users
>