On Thu, Jun 26, 2008 at 08:32:25PM +0200, Christian Theune wrote:
>  Hi,
>  
>  I think I didn't totally grasp the way that blob savepoints work correctly. At
>  one of our installations we have lots of .spb files left around. 
>  
>  Looking at the code I don't see where .spb files get cleaned up again on
>  savepoint aborts.

I reviewed the savepoint tests and see that they don't check for cleanup:
neither on rollback, nor on abort.

>  On the bushy branch I found that having the TmpStore create directory
>  structures is probably a bad idea. I propose to have it create a directory
>  `savepoints` in the temporary directory and create files called
>  `oidrepr-tidrepr.spb`.

I implemented this on the branch and it seems to work well. I find it easier
to inspect on the filesystem than having savepoint state being distributed
over the whole structure.

Christian

-- 
Christian Theune · ct@[...].com
gocept gmbh & co. kg · forsterstra�e 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1
Zope and Plone consulting and development
_______________________________________________
For more information about ZODB, see the ZODB Wiki:
http://www.zope.org/Wikis/ZODB/

ZODB-Dev mailing list  -  ZODB-Dev@[...].org
http://mail.zope.org/mailman/listinfo/zodb-dev