Re: [Zope-CMF] CMF 2.2 icon_expr vs. content_icon
by Yuppie other posts by this author
Nov 6 2009 1:57AM messages near this date
[Zope-CMF] CMF 2.2 icon_expr vs. content_icon
|
[Zope-CMF] CMF Tests: 4 OK
Martin Aspeli wrote:
> What's the reasoning behind having both a content_icon and an icon_expr
> property on FTIs in CMF 2.2?
>
> Apart from being really confusing, it seems that DynamicType.getIcon()
> returns fti.getIcon() (with some mangling), which returns self.content_icon.
>
> Hence, if you set an icon with icon_expr and leave content_icon,
> getIcon() always returns an empty string.
>
> This sounds like a bug to me, but I'm not sure how best to fix it:
>
> - remove one of content_icon and icon_expr?
> - make TypeInfo.getIcon() check both? If so, which takes precedence?
> - make Dynamictype.getIcon() check both? If so, which takes precedence?
See https://bugs.launchpad.net/zope-cmf/+bug/397795
Yuppie
_______________________________________________
Zope-CMF maillist - Zope-CMF@[...].org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Thread:
Martin Aspeli
Yuppie
|
